Conversation
Introduce a Cosmos signing implementation and protobuf-based tx encoding. Adds a new gem_cosmos signer module (chain_signer, protobuf, transaction) that can parse MsgExecuteContract and IBC MsgTransfer envelopes, build tx bodies/auth_info, and sign/encode transactions; includes unit tests and JSON testdata. Make the signer crate an optional feature of gem_cosmos and wire it into models and constants. Add low-level protobuf helpers, transaction encoding utilities, and expose secp256k1 public key helper from signer. Update primitives: add Cosmos denom mapping and extend SwapProvider with Squid; adjust preload gas estimation to account for non-Thorchain swap providers. Add serde_serializers for i32/u32 string-or-number deserialization and small SignerError/decoding error mappings and formatting helpers across signer/primitives for consistent error handling.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the platform's cross-chain swap capabilities by integrating Squid as a new swap provider. This integration allows users to perform swaps involving several Cosmos-based chains, such as Osmosis, Celestia, Injective, Sei, and Noble. The changes include the development of a dedicated Cosmos signer module to correctly encode and sign transactions for these new swap types, alongside adjustments to gas limit estimations to ensure smooth transaction processing. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for Squid swaps on Cosmos chains. It introduces a new signer feature in gem_cosmos to handle transaction signing for MsgExecuteContract and MsgTransfer messages, including a manual protobuf implementation for encoding. The changes are well-structured and include necessary updates to providers and models. My review focuses on improving error handling, performance of the protobuf encoding, and correctness of swap status mapping.
2 participants
No description provided.